Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: immediately setup EME if available #263

Merged
merged 2 commits into from
Oct 24, 2018
Merged

fix: immediately setup EME if available #263

merged 2 commits into from
Oct 24, 2018

Conversation

forbesjo
Copy link
Contributor

@forbesjo forbesjo commented Oct 17, 2018

Description

Uses a new videojs-contrib-eme API to set up EME immediately and not wait for encrypted
videojs/videojs-contrib-eme#61

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

gesinger
gesinger previously approved these changes Oct 22, 2018
Copy link
Contributor

@gesinger gesinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but looks good.

@@ -180,6 +180,10 @@ const setupEmeOptions = (hlsHandler) => {

if (sourceOptions) {
player.currentSource().keySystems = sourceOptions;

if (player.eme.initializeMediaKeys) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth it to add a comment pointing to the issue that we noticed.

@ldayananda ldayananda assigned ldayananda and unassigned ldayananda Oct 22, 2018
@forbesjo forbesjo merged commit 7577e90 into master Oct 24, 2018
@forbesjo forbesjo deleted the init-mediakeys branch October 24, 2018 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants